Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HACK week] Favorite products - Remote and storage code for synching favorite products using IDs #13998

Open
wants to merge 9 commits into
base: feat/12274-favorite-filter
Choose a base branch
from

Conversation

selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Sep 18, 2024

Part of: #12274

Description

Adds networking and storage related code for loading favorite products. We will use this code in an upcoming PR.

Changes

  • Adds a way to synchronize specific products using product IDs.
    • This will help us load the favorite products using product IDs in an upcoming PR.
  • Adds a way to specify product IDs in product list predicate.
  • Unit tests.

Steps to reproduce

Prerequisites

  • Use a Woo store with more than 100 products.
  • You can create a JN store and generate 100+ products using Woo Smooth generator.
  • Using the smooth generator helps to generate products with different types, status and category. (Helps with testing filters)

Steps

  • Login into the app
  • Navigate to Products tab
  • Tap "Filter"
  • Test by applying different filters
  • Validate that the product filtering works as expected

Testing information

  • Tested the product filtering works as before.

Screenshots

Simulator Screen Recording - iPhone 15 Pro Max - 2024-09-18 at 22 25 16


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@selanthiraiyan selanthiraiyan added the feature: product list Related to the product list. label Sep 18, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@selanthiraiyan selanthiraiyan changed the title [HACK week] Favorite products - Remote updates for synching using product IDs [HACK week] Favorite products - Remote and storage code for synching favorite products using IDs Sep 18, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13998-9b79d80
Version20.4
Bundle IDcom.automattic.alpha.woocommerce
Commit9b79d80
App Center BuildWooCommerce - Prototype Builds #10919
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@selanthiraiyan selanthiraiyan added this to the 20.6 milestone Sep 19, 2024
@selanthiraiyan selanthiraiyan marked this pull request as ready for review September 20, 2024 08:02
@itsmeichigo itsmeichigo self-assigned this Sep 23, 2024
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on simulator iPhone 15 Pro iOS 17.4 and confirmed that product filtering still works correctly as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product list Related to the product list.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants