[Woo POS] Update POS success view design #13969
Conversation
| @@ -204,11 +204,12 @@ private extension TotalsView { | |||
| .frame(minWidth: UIScreen.main.bounds.width / 2) | |||
| }) | |||
| .padding(Constants.newOrderButtonPadding) | |||
| .foregroundColor(Color.posPrimaryText) | |||
| .foregroundColor(.posPrimaryTextInverted) | |||
There was a problem hiding this comment.
I thought about creating a new Button style for this change, but since we only use it once across all flows I opted for the simplest change of creating a new colour.
|
|
| @@ -46,12 +46,30 @@ extension Color { | |||
| ) | |||
| } | |||
|
|
|||
| static var posOverlayFillInverted: Color { | |||
There was a problem hiding this comment.
If these colors are only used for the success button, I'm wondering if we should keep them within TotalsView. WDYT?
There was a problem hiding this comment.
Oops, alright I think I need new glasses 😂 that looks very funny. As you mention it didn't show before due to the overlay usage and the button's background matching the view's background. Addressed on c639cc6 by removing the overlay and applying the borders directly to the button's background:
There was a problem hiding this comment.
(Pressed save too fast )
| - | - |
|---|---|
 |
 |
If these colors are only used for the success button, I'm wondering if we should keep them within TotalsView. WDYT?
Agree! Updated on 72fdb6f
Closes: #13967
Description
This PR tackles the design review on TfaZ4LUkEwEGrxfnEFzvJj-fi-4665_22771 by:
Testing
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: