Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaze: Fix the layout of loading state and error state of objective picker view #13943

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Sep 12, 2024

Closes: #13942

Description

This PR adds a quick fix for the Blaze campaign objective picker by pushing the footer view to the bottom in the loading and error states.

Steps to reproduce

  • If you tested campaign objective before, log out of the app to clear the cached data.
  • Log in to a store eligible for Blaze.
  • Disconnect the internet connection.
  • Start the Blaze campaign creation flow and select the objective list.
  • Confirm that in the loading state, the footer is at the bottom of the screen.
  • When the request time out, confirm that in the error state, the footer is at the bottom of the screen.

Testing information

Screenshots

Before After

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: bug A confirmed bug. feature: Blaze Related to the integration of the Blaze ads platform labels Sep 12, 2024
@itsmeichigo itsmeichigo added this to the 20.4 milestone Sep 12, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 12, 2024

1 Warning
⚠️ This PR is assigned to the milestone 20.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 12, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13943-00e1db3
Version20.3
Bundle IDcom.automattic.alpha.woocommerce
Commit00e1db3
App Center BuildWooCommerce - Prototype Builds #10838
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review September 12, 2024 09:48
@hafizrahman hafizrahman self-assigned this Sep 12, 2024
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on a 13 inch iPad simulator and the positioning looks correct now in both cases.

@itsmeichigo itsmeichigo merged commit 0dadd69 into trunk Sep 13, 2024
14 checks passed
@itsmeichigo itsmeichigo deleted the fix/13942-blaze-objective-layout branch September 13, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Blaze Related to the integration of the Blaze ads platform type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blaze: Update layout for the loading and error states of the objective picker
4 participants