Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on various Settings screen #12657

Merged
merged 2 commits into from
May 7, 2024

Conversation

itsmeichigo
Copy link
Contributor

Closes: #12656

Description

In #12602 I removed the Dashboard storyboard which contains screens related to the Settings flow. This causes crashes when open Help & Support, Application Log, Privacy, and About screens from Settings.

This PR fixes this by restoring the old Dashboard storyboard. To avoid misunderstanding in the future, I also renamed this storyboard to Settings.

Testing instructions

  • Log in to the app.
  • Navigate to Menu tab > Settings.
  • Select Help & Support and confirm that the app doesn't crash.
  • Select View Application Log and confirm that the app doesn't crash.
  • Navigate back to the Settings screen and select Privacy Settings. Confirm that the app doesn't crash.
  • Navigate back and select WooCommerce in the About the app section. Confirm that the app doesn't crash.

Screenshots

About Privacy Help Application Log

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added feature: app settings Related to settings accessed via the gear icon in the My Store section. type: crash The worst kind of bug. labels May 7, 2024
@itsmeichigo itsmeichigo added this to the 18.5 ❄️ milestone May 7, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 18.5 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@hafizrahman hafizrahman self-assigned this May 7, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12657-5b4fa65
Version18.5
Bundle IDcom.automattic.alpha.woocommerce
Commit5b4fa65
App Center BuildWooCommerce - Prototype Builds #8965
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. This LGTM 👍🏼

@itsmeichigo itsmeichigo merged commit bd25789 into release/18.5 May 7, 2024
28 of 32 checks passed
@itsmeichigo itsmeichigo deleted the crash/12656-help-and-support branch May 7, 2024 06:13
@itsmeichigo
Copy link
Contributor Author

@iamgabrielma Please help with a beta build for this fix, thank you 🙏

@iamgabrielma
Copy link
Contributor

Done! 18.5.0.1 published and back merged #12662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: app settings Related to settings accessed via the gear icon in the My Store section. type: crash The worst kind of bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants