Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'Suggested by AI' label under the description #12671

Closed

Conversation

rossanafmenezes
Copy link
Contributor

@rossanafmenezes rossanafmenezes commented Sep 23, 2024

Closes: #11834

Description

This PR moves the 'Suggested by AI' label under the product description text, inside the card like on iOS

Steps to reproduce

  1. Go to Menu
  2. Blaze
  3. Select a product
  4. Note the label placement within the card

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitf3e33a8
Direct Downloadwoocommerce-wear-prototype-build-pr12671-f3e33a8.apk

@rossanafmenezes rossanafmenezes requested review from JorgeMucientes and removed request for JorgeMucientes September 23, 2024 17:01
@rossanafmenezes rossanafmenezes added type: enhancement A request for an enhancement. feature: blaze Related to the Blaze project labels Sep 23, 2024
@rossanafmenezes rossanafmenezes added this to the 20.7 milestone Sep 23, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitf3e33a8
Direct Downloadwoocommerce-prototype-build-pr12671-f3e33a8.apk

@JorgeMucientes JorgeMucientes self-assigned this Sep 24, 2024
@JorgeMucientes
Copy link
Contributor

Hey @rossanafmenezes thanks so much for working on this :)

Just wanted to let you know that I started a discussion around it, because I'm not sure we should apply this change. Once a decision is being made I'll update the PR :)
Discussion: p1727177421848799-slack-C03L1NF1EA3

@JorgeMucientes
Copy link
Contributor

Hey @rossanafmenezes, we got some feedback from Joe suggesting to keep the label outside the preview section, so we agreed to keep it that way. I'm afraid we'll have to discard this change :(
Context: p1727229167910209/1727177421.848799-slack-C03L1NF1EA3

I'll proceed to close the PR. But thanks for jumping into handling this anyway 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: blaze Related to the Blaze project type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blaze i3: move "Generated with AI" label under description
3 participants