-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/12494 blaze webview fragment #12648
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
While I added unit test to the new viewModel, the lint checks still fail stating the following:
That doesn't make sense, so I'm adding the |
Yes, that's what I would do to, adding unit tests for a plain class like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @JorgeMucientes, it works well, I left a minor suggestion, but it's not a blocker.
blazeUrlsHelper.buildCampaignsListUrl() == url -> onDismiss() | ||
url.contains(blazeUrlsHelper.getCampaignStopUrlPath(navArgs.campaignId)) -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor, I would suggest caching the results of blazeUrlsHelper.buildCampaignsListUrl()
and blazeUrlsHelper.getCampaignStopUrlPath(navArgs.campaignId)
and use the cached values instead of calling the functions here again and again, the onUrlLoaded
will be called quite often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Applied!
Closes: #12494 and #12547
Description
This PR adds 3 things:
Testing information
The tests that have been performed
Images/gif
demo.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: