Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate security lint checks #12645

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Integrate security lint checks #12645

merged 1 commit into from
Sep 23, 2024

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Sep 19, 2024

Description

This PR integrates additional Android Lint checks, focused on security: https://github.com/google/android-security-lints?tab=readme-ov-file

Testing Instructions

Compare:

This report from this branch should have more security Lint issues.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit802aac2
Direct Downloadwoocommerce-wear-prototype-build-pr12645-802aac2.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit802aac2
Direct Downloadwoocommerce-prototype-build-pr12645-802aac2.apk

@wzieba wzieba added type: enhancement A request for an enhancement. category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. labels Sep 19, 2024
@wzieba wzieba added this to the 20.5 milestone Sep 19, 2024
@wzieba wzieba marked this pull request as ready for review September 19, 2024 15:01
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @wzieba !

I have reviewed this PR as per the instructions, great checks addition, Lint security for the win, for (almost) free! 🎉

Question (❓): Will the Lint Sarif work help comment on PRs with these issues? I am trying to figure out the discoverability effort of how developers will see and act on them.

@wpmobilebot wpmobilebot modified the milestones: 20.5, 20.6 Sep 20, 2024
@wpmobilebot
Copy link
Collaborator

Version 20.5 has now entered code-freeze, so the milestone of this PR has been updated to 20.6.

@wzieba
Copy link
Contributor Author

wzieba commented Sep 23, 2024

Thanks @ParaskP7 for the review! Yes, the GitHub Code Scanning (enabled by sending lint sarif files) should also highlight theses new issues!

@wzieba wzieba merged commit 8323b7c into trunk Sep 23, 2024
19 of 20 checks passed
@wzieba wzieba deleted the lint_security_checks branch September 23, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants