-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] in landscape marking as paid with cash keeps user on collect payment screen #12632
base: trunk
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…h-keeps-user-on-collect-payment-screen
…h-keeps-user-on-collect-payment-screen
…_orders" /> doesn't seem to work
…h-keeps-user-on-collect-payment-screen
@@ -244,8 +245,11 @@ class SelectPaymentMethodFragment : BaseFragment(R.layout.fragment_select_paymen | |||
// We should pop the back stack to show the [OrderDetailsFragment]. | |||
findNavController().popBackStack() | |||
} else { | |||
if (isFragmentInBackStack(R.id.selectPaymentMethodFragment)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one partial fix if we can't come up with a better solution. But it only takes us back to the order detail screen.
…h-keeps-user-on-collect-payment-screen
Closes: #11661
Slack discussion.
Description
Addresses the issue where marking an order as paid with cash when switching from landscape mode to single pane mode keeps the user on the collect payment screen instead of redirecting them to the order list.
Problem:
When the device is in landscape mode, marking an order as paid via cash completes the operation behind the scenes, but the user remains on the collect payment screen.
Steps to reproduce
Alternate steps that @samiuelson and I discovered (seems to be the same underlying issue):
Testing information
The tests that have been performed
Verified the navigation flow in both portrait and landscape modes.
Ensured no regressions in the collect payment screen.
I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: