Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Animated transition to the Get Support screen #12630

Open
wants to merge 19 commits into
base: trunk
Choose a base branch
from

Conversation

samiuelson
Copy link
Collaborator

@samiuelson samiuelson commented Sep 17, 2024

Closes: #12628

Description

This PR attempts to animate the transition to the Get Support screen as per design feedback and animations specs (p6riRB-aNq-p2).

Screenshot 2024-09-17 at 12 44 58

Steps to reproduce

  1. Enter POS mode
  2. Tap "Get Support" from the bottom menu
  3. Observe transition to the support screen

Testing information

Transitions should follow animation specs (see above), and animate by sliding horizontally between screens.

The tests that have been performed

As shown in the section below, I checked the animations of transitions when entering and exiting the "Get Support" screen. In the store management mode, the transitions should remain unchanged.

Devices: Galaxy Tab S9 FE, Android 14

Images/gif

Before

Screen_recording_20240917_124211.mp4

After

Screen_recording_20240917_120252.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 17, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit4065455
Direct Downloadwoocommerce-wear-prototype-build-pr12630-4065455.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 17, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit4065455
Direct Downloadwoocommerce-prototype-build-pr12630-4065455.apk

@samiuelson samiuelson added this to the 20.5 milestone Sep 17, 2024
@samiuelson samiuelson marked this pull request as ready for review September 17, 2024 11:23
@backwardstruck
Copy link
Contributor

I think this is the issue you meant to link:
#12628

@backwardstruck backwardstruck self-assigned this Sep 17, 2024
@samiuelson
Copy link
Collaborator Author

Thanks for review, @kidinov! I updated the animations:

Screen_recording_20240918_104438.mp4

Let me know what you think.

@kidinov
Copy link
Contributor

kidinov commented Sep 18, 2024

@samiuelson, my understanding is that we should have something like this (no alpha, just moving from the right to left and backwards). The animations from android do have alpha so custom are needed

Here is the patch for android 34+
Animation_for_34+.patch

09-18--17-05.mp4

For Android <34, we also need to add overridePendingTransition in the activity's finish method to have proper back animation

@samiuelson samiuelson marked this pull request as draft September 19, 2024 16:47
@samiuelson
Copy link
Collaborator Author

samiuelson commented Sep 20, 2024

@samiuelson, my understanding is that we should have something like this (no alpha, just moving from the right to left and backwards). The animations from android do have alpha so custom are needed

Makes sense, updated — 278c0b8

For Android <34, we also need to add overridePendingTransition in the activity's finish method to have proper back animation

Good catch, fixed:

pre-34.mp4

Let me know what you think, @kidinov.

@samiuelson samiuelson marked this pull request as ready for review September 20, 2024 08:40
@samiuelson
Copy link
Collaborator Author

👋🏼 @backwardstruck, @kidinov, this is ready for review again.

Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samiuelson

  • I think on Android <34 it slides in the opposite direction it should (from left to right)
  • Can we just override finish method instead of calling adjustExitTransition from multiples places? I haven't tried it, but I recall that was the way
    override fun finish() {
        adjustExitTransition()
        super.finish()
    }
09-20--15-37.mp4

@wpmobilebot wpmobilebot modified the milestones: 20.5, 20.6 Sep 20, 2024
@wpmobilebot
Copy link
Collaborator

Version 20.5 has now entered code-freeze, so the milestone of this PR has been updated to 20.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Animate transition to "Get support" screen
4 participants