Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] UI issues fix with the cart screen #12621

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Sep 16, 2024

Closes: #12618

Description

The PR:

  • Fixes the broken top shadow and missing bottom shadow for the cart products list
  • The fade-out animation is too long -> get it back to 300
  • The animation of the back arrow is too long -> get it back to 300
  • Changed outer padding from 32 to 24 on the products banner to match the design
  • And the cart not aligned with the products again was fixed on the trunk already

Testing information

Open the POS, notice the changes from the description. Try dark mode too

The tests that have been performed

Only what in the testing information

Images/gif

09-16--15-09.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov linked an issue Sep 16, 2024 that may be closed by this pull request
@@ -64,110 +64,105 @@ fun WooPosBanner(
modifier = Modifier
.fillMaxWidth()
) {
Box(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant box was here

@kidinov kidinov added the feature: point of sale POS project label Sep 16, 2024
@kidinov kidinov added this to the 20.5 milestone Sep 16, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit97cac80
Direct Downloadwoocommerce-wear-prototype-build-pr12621-97cac80.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit97cac80
Direct Downloadwoocommerce-prototype-build-pr12621-97cac80.apk

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 40.61%. Comparing base (2a89ace) to head (97cac80).
Report is 26 commits behind head on trunk.

Files with missing lines Patch % Lines
...ce/android/ui/woopos/home/products/WooPosBanner.kt 0.00% 29 Missing ⚠️
...pos/common/composeui/component/WooPosLazyColumn.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #12621   +/-   ##
=========================================
  Coverage     40.60%   40.61%           
  Complexity     5683     5683           
=========================================
  Files          1230     1230           
  Lines         69159    69156    -3     
  Branches       9575     9575           
=========================================
  Hits          28085    28085           
+ Misses        38493    38490    -3     
  Partials       2581     2581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@AnirudhBhat AnirudhBhat self-assigned this Sep 17, 2024
@AnirudhBhat AnirudhBhat merged commit 2c07c11 into trunk Sep 17, 2024
16 of 17 checks passed
@AnirudhBhat AnirudhBhat deleted the 12618-woo-pos-ui-issues-with-the-cart-screen branch September 17, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] UI issues with the cart screen
4 participants