-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] UI issues fix with the cart screen #12621
[Woo POS] UI issues fix with the cart screen #12621
Conversation
@@ -64,110 +64,105 @@ fun WooPosBanner( | |||
modifier = Modifier | |||
.fillMaxWidth() | |||
) { | |||
Box( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant box was here
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12621 +/- ##
=========================================
Coverage 40.60% 40.61%
Complexity 5683 5683
=========================================
Files 1230 1230
Lines 69159 69156 -3
Branches 9575 9575
=========================================
Hits 28085 28085
+ Misses 38493 38490 -3
Partials 2581 2581 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #12618
Description
The PR:
And the cart not aligned with the products againwas fixed on the trunk alreadyTesting information
Open the POS, notice the changes from the description. Try dark mode too
The tests that have been performed
Only what in the testing information
Images/gif
09-16--15-09.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: