-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Product Variation Attributes] Do not use ignore case when renaming attributes #12608
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12608 +/- ##
============================================
+ Coverage 40.61% 40.63% +0.02%
- Complexity 5685 5687 +2
============================================
Files 1230 1230
Lines 69167 69167
Branches 9575 9575
============================================
+ Hits 28093 28109 +16
+ Misses 38493 38474 -19
- Partials 2581 2584 +3 ☔ View full report in Codecov by Sentry. |
Closes: #12561
Description
With this PR we fix the issue that was preventing users from renaming their variation attributes from a different case (upper to lower or vice-versa)
Note: there are other cases where we ignore the case for attributes: when adding a new attribute, or when deleting them. I preferred to leave them like that as we could have unexpected cases if we modified. For renaming it's ok though, as this case is isolated enough.
Steps to reproduce
Testing information
See steps to reproduce
The tests that have been performed
I ensured with the steps to reproduce that it's working properly. I also verified it in wc-admin
Images/gif
Before
CannotRename.mp4
After
Screen_Recording_20240913_160949_WooCommerce.Dev.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: