-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Fix shadow clipping #12588
base: trunk
Are you sure you want to change the base?
[Woo POS] Fix shadow clipping #12588
Conversation
…gers the addition of a shadow to the bottom of the LazyColumn. However, because this shadow is applied within the Box and flipped, it might be extending or spilling over in an unintended way, visually affecting both the top and bottom of the component.
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #12588 +/- ##
=========================================
Coverage 40.58% 40.58%
- Complexity 5674 5675 +1
=========================================
Files 1229 1229
Lines 69287 69287
Branches 9579 9579
=========================================
+ Hits 28119 28120 +1
Misses 38584 38584
+ Partials 2584 2583 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Version |
Closes:
Closes: #12575
Description
Addresses the visual issue where the shadow at the top of the extended above the intended area. The shadow for the bottom of the
LazyColumn
was being applied within aBox
and rotated, causing it to spill over.Steps to reproduce
Testing information
Images/gif
Before:
After:
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: