-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no campaign reminder shown logic #12581
Fix no campaign reminder shown logic #12581
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/20.3 #12581 +/- ##
==================================================
- Coverage 40.61% 40.61% -0.01%
+ Complexity 5633 5632 -1
==================================================
Files 1223 1223
Lines 68605 68605
Branches 9474 9474
==================================================
- Hits 27862 27861 -1
Misses 38186 38186
- Partials 2557 2558 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This fixes a bug that was introduced in #12452. It was introduced in version 20.3 and should be addressed in
release/20.3
.4d55dbc:
Testing information
No need to test. Reviewing the rationale should be sufficient, as we have already tested the feature in #12374.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: