Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no campaign reminder shown logic #12581

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Sep 11, 2024

Description

This fixes a bug that was introduced in #12452. It was introduced in version 20.3 and should be addressed in release/20.3.

4d55dbc:

Screenshot 2024-09-11 at 18 29 25

Testing information

No need to test. Reviewing the rationale should be sufficient, as we have already tested the feature in #12374.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added type: bug A confirmed bug. feature: blaze Related to the Blaze project labels Sep 11, 2024
@irfano irfano added this to the 20.3 ❄️ milestone Sep 11, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 20.3 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit4c74cc5
Direct Downloadwoocommerce-wear-prototype-build-pr12581-4c74cc5.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit4c74cc5
Direct Downloadwoocommerce-prototype-build-pr12581-4c74cc5.apk

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.61%. Comparing base (2fb76b3) to head (4c74cc5).
Report is 2 commits behind head on release/20.3.

Files with missing lines Patch % Lines
...oid/notifications/local/LocalNotificationWorker.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/20.3   #12581      +/-   ##
==================================================
- Coverage           40.61%   40.61%   -0.01%     
+ Complexity           5633     5632       -1     
==================================================
  Files                1223     1223              
  Lines               68605    68605              
  Branches             9474     9474              
==================================================
- Hits                27862    27861       -1     
  Misses              38186    38186              
- Partials             2557     2558       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hichamboushaba hichamboushaba merged commit 4f17979 into release/20.3 Sep 12, 2024
15 of 17 checks passed
@hichamboushaba hichamboushaba deleted the fix/no-campaign-reminder-shown-logic branch September 12, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: blaze Related to the Blaze project type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants