-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Custom Fields] Support for copying key and value #12579
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #12579 +/- ##
=========================================
Coverage 40.63% 40.64%
- Complexity 5668 5670 +2
=========================================
Files 1228 1228
Lines 68930 68938 +8
Branches 9547 9547
=========================================
+ Hits 28011 28019 +8
Misses 38345 38345
Partials 2574 2574 ☔ View full report in Codecov by Sentry. |
R.string.custom_fields_editor_copy_key, | ||
R.string.custom_fields_editor_copy_value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These entries will be shown even when the key or value are empty, I thought about hiding them when they are, but I didn't implement it because I think it'll complicate the logic for not much added value, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected and code looks good.
Closes: #12578
Description
This PR adds two menu entries to the overflow menu to allow copying either the key or the value of the custom field.
Steps to reproduce
Testing information
Test copying the key and the value
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: