-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/12539 blaze push notification navigation #12564
Merged
JorgeMucientes
merged 19 commits into
trunk
from
issue/12539-blaze-push-notification-navigation
Sep 11, 2024
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8976180
Simplifies code handling taps on push notifications
JorgeMucientes 557e86a
Open campaign list from Blaze push notification and pass the campaign_id
JorgeMucientes 2fe3177
Add missing mapping for Blaze push notification type
JorgeMucientes 8e1e434
Open campaign detail directly when tapping on Blaze notification
JorgeMucientes 32c26a6
Updates FluxC changeset
JorgeMucientes 24fdc33
Set more consistent naming
JorgeMucientes 0fe2a3e
Add new tests for Blaze notifications taps
JorgeMucientes 58c24cc
Fix detekt indentation issue
JorgeMucientes 542fb2d
Ensure campaign detail is loaded when a campaign id is passed
JorgeMucientes 72cec8e
Handle Blaze grouped notifications
JorgeMucientes 9f8fc2a
Keep the same Blaze notification types received in push payload
JorgeMucientes 3684707
Fix detekt indentation issues
JorgeMucientes 05172e9
Fix existing unit tests after group notification implementation updates
JorgeMucientes 3b8502d
Add unit tests fro group notification handling
JorgeMucientes 905cf74
Update FluxC changeset
JorgeMucientes 37069bf
Merge branch 'refs/heads/trunk' into issue/12539-blaze-push-notificat…
JorgeMucientes 9f4dd30
Avoid waiting for campaigns to be loaded before loading campaign detail
JorgeMucientes 12b9b3a
Avoid tracking campaign detail tapped event
JorgeMucientes 318fe1f
Fix unit tests compilation issue
JorgeMucientes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion for a future improvement: can't we improve the API a bit if we convert
WooNotificationType
to be a sealed interface instead of anenum
? I think if we do so we'll have a common parent for Blaze notification types.