-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Fixes for UI Changes on Exit POS Dialog and Product Info Icon Color Update #12546
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12546 +/- ##
============================================
- Coverage 40.60% 40.60% -0.01%
Complexity 5671 5671
============================================
Files 1228 1228
Lines 69024 69025 +1
Branches 9562 9562
============================================
Hits 28028 28028
- Misses 38419 38420 +1
Partials 2577 2577 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
df55d33
to
ca5cf1f
Compare
…os-dialog # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/products/WooPosProductsScreen.kt
Closes: #12527
Description
This PR addresses UI improvements related to the Exit POS dialog and product screen toolbar.
Changes Included:
Remove Shadow from the Primary Button in the Exit POS Dialog:
The shadow effect on the primary button in the Exit POS dialog has been removed to align with the design.
Update Behavior of Exit POS Mode:
When a user exits the POS mode, the Exit POS dialog will now dismiss first, followed by the exit of the POS mode screen.
Product Info Icon Color Update:
The color of the product info icon in the toolbar on the product screen has been changed to match the design.
Testing information
The tests that have been performed
Tested Exit POS dialog and product info icon color on both light and dark modes.
Images/gif
exit_pos_ui_changes.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: