Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Fixes for UI Changes on Exit POS Dialog and Product Info Icon Color Update #12546

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

AnirudhBhat
Copy link
Contributor

@AnirudhBhat AnirudhBhat commented Sep 6, 2024

Closes: #12527

Description

This PR addresses UI improvements related to the Exit POS dialog and product screen toolbar.

Changes Included:
Remove Shadow from the Primary Button in the Exit POS Dialog:

The shadow effect on the primary button in the Exit POS dialog has been removed to align with the design.

Update Behavior of Exit POS Mode:

When a user exits the POS mode, the Exit POS dialog will now dismiss first, followed by the exit of the POS mode screen.

Product Info Icon Color Update:

The color of the product info icon in the toolbar on the product screen has been changed to match the design.

Testing information

  1. Ensure the shadow is completely removed from the primary button in the Exit POS dialog.
  2. Verify that the Exit POS dialog dismisses first, and the app transitions out of POS mode.
  3. Confirm that the new product info icon color is as per design.

The tests that have been performed

Tested Exit POS dialog and product info icon color on both light and dark modes.

Images/gif

exit_pos_ui_changes.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: task An internally driven task. feature: point of sale POS project labels Sep 6, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 6, 2024

1 Warning
⚠️ This PR is assigned to the milestone 20.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 6, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitd0d06c8
Direct Downloadwoocommerce-wear-prototype-build-pr12546-d0d06c8.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 6, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitd0d06c8
Direct Downloadwoocommerce-prototype-build-pr12546-d0d06c8.apk

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.60%. Comparing base (1df562a) to head (d0d06c8).
Report is 11 commits behind head on trunk.

Files with missing lines Patch % Lines
...woopos/common/composeui/component/WooPosButtons.kt 0.00% 5 Missing ⚠️
...omposeui/component/WooPosExitConfirmationDialog.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #12546      +/-   ##
============================================
- Coverage     40.60%   40.60%   -0.01%     
  Complexity     5671     5671              
============================================
  Files          1228     1228              
  Lines         69024    69025       +1     
  Branches       9562     9562              
============================================
  Hits          28028    28028              
- Misses        38419    38420       +1     
  Partials       2577     2577              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnirudhBhat AnirudhBhat marked this pull request as ready for review September 6, 2024 07:22
@samiuelson samiuelson self-assigned this Sep 11, 2024
Copy link
Collaborator

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@AnirudhBhat AnirudhBhat added this to the 20.4 milestone Sep 12, 2024
@AnirudhBhat AnirudhBhat force-pushed the issue/12527-ui-changes-on-exit-pos-dialog branch from df55d33 to ca5cf1f Compare September 12, 2024 05:18
…os-dialog

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/products/WooPosProductsScreen.kt
@AnirudhBhat AnirudhBhat merged commit 99dc105 into trunk Sep 12, 2024
14 checks passed
@AnirudhBhat AnirudhBhat deleted the issue/12527-ui-changes-on-exit-pos-dialog branch September 12, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: point of sale POS project type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WOO POS] UI changes on Exit POS dialog
5 participants