Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release builds #10206

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Fix release builds #10206

merged 1 commit into from
Nov 19, 2023

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Nov 19, 2023 •
edited
Loading

Description

This PR fixes the release builds, the builds started failing in the release/16.2 branch, probably due to the PR #10141 which updated a bunch of libraries.
The fix adds rules to ignore warnings about missing classes, the rules are generated by AGP in the file "missing_rules.txt" after the failure, I smoke-tested the app, and everything works fine, which confirms these are false warnings.

Testing instructions

Confirm release builds succeed, and smoke test the app using it.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hichamboushaba
Update proguard rules to fix build
8ce64d5 
This adds new rules generated by AGP
@hichamboushaba hichamboushaba added category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. Releases Used in release management. Using this label will skip some bot checks. labels Nov 19, 2023
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit8ce64d5
Direct Downloadwoocommerce-prototype-build-pr10206-8ce64d5.apk

0nko
0nko approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@0nko 0nko merged commit f91258f into release/16.2 Nov 19, 2023
15 checks passed
@0nko 0nko deleted the fix-build branch November 19, 2023 12:58
@spencertransier spencertransier mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0nko 0nko 0nko approved these changes

@spencertransier spencertransier Awaiting requested review from spencertransier

Assignees
No one assigned
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. Releases Used in release management. Using this label will skip some bot checks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hichamboushaba @wpmobilebot @0nko