[Woo POS] Animated transition to the Get Support screen #12630

samiuelson · 2024-09-17T09:50:37Z

Description

This PR attempts to animate the transition to the Get Support screen as per design feedback and animations specs (p6riRB-aNq-p2).

Steps to reproduce

Enter POS mode
Tap "Get Support" from the bottom menu
Observe transition to the support screen

Testing information

Transitions should follow animation specs (see above), and animate by sliding horizontally between screens.

The tests that have been performed

As shown in the section below, I checked the animations of transitions when entering and exiting the "Get Support" screen. In the store management mode, the transitions should remain unchanged.

Devices: Galaxy Tab S9 FE, Android 14

Images/gif

Before

Screen_recording_20240917_124211.mp4

After

Screen_recording_20240917_120252.mp4

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

wpmobilebot · 2024-09-17T09:56:30Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`a713b1a`
	Direct Download	`woocommerce-wear-prototype-build-pr12630-a713b1a.apk`

wpmobilebot · 2024-09-17T10:11:29Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`a713b1a`
	Direct Download	`woocommerce-prototype-build-pr12630-a713b1a.apk`

...merce/src/main/kotlin/com/woocommerce/android/support/requests/SupportRequestFormActivity.kt

backwardstruck · 2024-09-17T18:15:32Z

I think this is the issue you meant to link:
#12628

- Reuse android ones - Update duration

samiuelson · 2024-09-18T08:47:00Z

Thanks for review, @kidinov! I updated the animations:

Screen_recording_20240918_104438.mp4

Let me know what you think.

kidinov · 2024-09-18T15:09:05Z

@samiuelson, my understanding is that we should have something like this (no alpha, just moving from the right to left and backwards). The animations from android do have alpha so custom are needed

Here is the patch for android 34+
Animation_for_34+.patch

09-18--17-05.mp4

For Android <34, we also need to add overridePendingTransition in the activity's finish method to have proper back animation

…screen' into 12628-transition-to-get-support-screen

samiuelson · 2024-09-20T08:40:26Z

@samiuelson, my understanding is that we should have something like this (no alpha, just moving from the right to left and backwards). The animations from android do have alpha so custom are needed

Makes sense, updated — 278c0b8

For Android <34, we also need to add overridePendingTransition in the activity's finish method to have proper back animation

Good catch, fixed:

pre-34.mp4

Let me know what you think, @kidinov.

…screen' into 12628-transition-to-get-support-screen

samiuelson · 2024-09-20T13:30:06Z

👋🏼 @backwardstruck, @kidinov, this is ready for review again.

kidinov

Can we just override finish method instead of calling adjustExitTransition from multiples places? I haven't tried it, but I recall that was the way
    override fun finish() {
        adjustExitTransition()
        super.finish()
    }

Good catch, thanks @kidinov ! I think it should be called right after super.finish(); Fixed – a1fe6af

I think on Android <34 it slides in the opposite direction it should (from left to right)

Fixed – efb7e35

wpmobilebot · 2024-09-20T19:57:55Z

Version 20.5 has now entered code-freeze, so the milestone of this PR has been updated to 20.6.

…screen' into 12628-transition-to-get-support-screen

dangermattic · 2024-09-25T10:16:38Z

	1 Warning
⚠️	This PR is assigned to the milestone 20.6. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

kidinov

Looks great!

I removed unused import to make it mergable

a713b1a

Implement transition to the Get Support screen

6064160

Merge branch 'trunk' into 12628-transition-to-get-support-screen

0f87fab

samiuelson added this to the 20.5 milestone Sep 17, 2024

samiuelson added the feature: point of sale POS project label Sep 17, 2024

samiuelson marked this pull request as ready for review September 17, 2024 11:23

samiuelson mentioned this pull request Sep 17, 2024

[Woo POS] Animate transition to "Get support" screen #12628

Closed

samiuelson requested a review from backwardstruck September 17, 2024 11:32

kidinov reviewed Sep 17, 2024

View reviewed changes

...merce/src/main/kotlin/com/woocommerce/android/support/requests/SupportRequestFormActivity.kt Outdated Show resolved Hide resolved

kidinov reviewed Sep 17, 2024

View reviewed changes

...merce/src/main/kotlin/com/woocommerce/android/support/requests/SupportRequestFormActivity.kt Outdated Show resolved Hide resolved

kidinov reviewed Sep 17, 2024

View reviewed changes

...merce/src/main/kotlin/com/woocommerce/android/support/requests/SupportRequestFormActivity.kt Show resolved Hide resolved

Merge branch 'trunk' into 12628-transition-to-get-support-screen

d85478d

backwardstruck self-assigned this Sep 17, 2024

samiuelson added 6 commits September 18, 2024 09:49

Update transition animation specs

afc7e26

- Reuse android ones - Update duration

Simplify isPOS() fun

d7548d1

Change animation to slide-in right

4a790bb

Simplify the code

7a8b219

Satisfy detekt's complaints

3fd1d72

Merge branch 'trunk' into 12628-transition-to-get-support-screen

630e1bc

samiuelson requested a review from kidinov September 18, 2024 08:46

backwardstruck and others added 4 commits September 18, 2024 13:48

Merge branch 'trunk' into 12628-transition-to-get-support-screen

b45a384

Update animation specs

278c0b8

Fix transition on OS level < 34

95df2c9

Merge remote-tracking branch 'origin/12628-transition-to-get-support-…

0d3209f

…screen' into 12628-transition-to-get-support-screen

samiuelson marked this pull request as draft September 19, 2024 16:47

Fix condition for transition on OS level < 34

2079978

Fix transition implementation on OS level < 34

1db5696

samiuelson marked this pull request as ready for review September 20, 2024 08:40

samiuelson added 3 commits September 20, 2024 10:40

Merge branch 'trunk' into 12628-transition-to-get-support-screen

7d7aca7

Clean up code

9dcdaf0

Merge remote-tracking branch 'origin/12628-transition-to-get-support-…

35b2a7d

…screen' into 12628-transition-to-get-support-screen

kidinov reviewed Sep 20, 2024

View reviewed changes

Merge branch 'trunk' into 12628-transition-to-get-support-screen

4065455

wpmobilebot modified the milestones: 20.5, 20.6 Sep 20, 2024

samiuelson added 3 commits September 25, 2024 12:12

Clean up code by overriding finish()

a1fe6af

Fix animation sliding directions

efb7e35

Merge remote-tracking branch 'origin/12628-transition-to-get-support-…

5cd9abb

…screen' into 12628-transition-to-get-support-screen

samiuelson requested a review from kidinov September 25, 2024 10:16

samiuelson and others added 2 commits September 25, 2024 12:17

Merge branch 'trunk' into 12628-transition-to-get-support-screen

a7d8beb

Removed unused import

a713b1a

kidinov approved these changes Sep 25, 2024

View reviewed changes

kidinov enabled auto-merge September 25, 2024 14:58

kidinov self-assigned this Sep 25, 2024

kidinov merged commit 025fca0 into trunk Sep 25, 2024
14 of 15 checks passed

kidinov deleted the 12628-transition-to-get-support-screen branch September 25, 2024 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Woo POS] Animated transition to the Get Support screen #12630

[Woo POS] Animated transition to the Get Support screen #12630

samiuelson commented Sep 17, 2024 •

edited by kidinov

Loading

wpmobilebot commented Sep 17, 2024 •

edited

Loading

wpmobilebot commented Sep 17, 2024 •

edited

Loading

backwardstruck commented Sep 17, 2024

samiuelson commented Sep 18, 2024

kidinov commented Sep 18, 2024 •

edited

Loading

samiuelson commented Sep 20, 2024 •

edited

Loading

samiuelson commented Sep 20, 2024

kidinov left a comment •

edited by samiuelson

Loading

wpmobilebot commented Sep 20, 2024

dangermattic commented Sep 25, 2024

kidinov left a comment

[Woo POS] Animated transition to the Get Support screen #12630

[Woo POS] Animated transition to the Get Support screen #12630

Conversation

samiuelson commented Sep 17, 2024 • edited by kidinov Loading

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

Before

After

Reviewer (or Author, in the case of optional code reviews):

wpmobilebot commented Sep 17, 2024 • edited Loading

wpmobilebot commented Sep 17, 2024 • edited Loading

backwardstruck commented Sep 17, 2024

samiuelson commented Sep 18, 2024

kidinov commented Sep 18, 2024 • edited Loading

samiuelson commented Sep 20, 2024 • edited Loading

samiuelson commented Sep 20, 2024

kidinov left a comment • edited by samiuelson Loading

Choose a reason for hiding this comment

wpmobilebot commented Sep 20, 2024

dangermattic commented Sep 25, 2024

kidinov left a comment

Choose a reason for hiding this comment

samiuelson commented Sep 17, 2024 •

edited by kidinov

Loading

wpmobilebot commented Sep 17, 2024 •

edited

Loading

wpmobilebot commented Sep 17, 2024 •

edited

Loading

kidinov commented Sep 18, 2024 •

edited

Loading

samiuelson commented Sep 20, 2024 •

edited

Loading

kidinov left a comment •

edited by samiuelson

Loading