Extract logic to url helper

woocommerce · Sep 23, 2024 · 91052fc · 91052fc
1 parent 5a7d36c
commit 91052fc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/blaze/BlazeUrlsHelper.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/blaze/BlazeUrlsHelper.kt
@@ -20,6 +20,11 @@ class BlazeUrlsHelper @Inject constructor(
 
     private fun getSiteUrl() = selectedSite.get().url.replace(Regex(HTTP_PATTERN), "")
 
+    fun extractProductIdFromPromoteAgainUrl(url: String): Long? =
+        url.substringAfter("post-")
+            .substringBefore("_campaign")
+            .toLongOrNull()
+
     enum class BlazeFlowSource(val trackingName: String) {
         MORE_MENU_ITEM("menu"),
         PRODUCT_DETAIL_PROMOTE_BUTTON("product_detail_promote_button"),

diff --git a/...ain/kotlin/com/woocommerce/android/ui/blaze/detail/BlazeCampaignDetailWebViewViewModel.kt b/...ain/kotlin/com/woocommerce/android/ui/blaze/detail/BlazeCampaignDetailWebViewViewModel.kt
@@ -35,18 +35,15 @@ class BlazeCampaignDetailWebViewViewModel @Inject constructor(
 
             url.contains(BlazeUrlsHelper.PROMOTE_AGAIN_URL_PATH) -> {
                 viewState = viewState.copy(
-                    blazeAction = PromoteProductAgain(productId = extractProductIdFromUrl(url))
+                    blazeAction = PromoteProductAgain(
+                        productId = blazeUrlsHelper.extractProductIdFromPromoteAgainUrl(url)
+                    )
                 )
                 onDismiss()
             }
         }
     }
 
-    private fun extractProductIdFromUrl(url: String): Long? =
-        url.substringAfter("post-")
-            .substringBefore("_campaign")
-            .toLongOrNull()
-
     fun onDismiss() {
         when (viewState.blazeAction) {
             None -> triggerEvent(Exit)