Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some of the plugin check errors and warnings #2772

Merged
merged 6 commits into from
Jan 17, 2025

WP functions are not available in scripts

b371832
Select commit
Loading
Failed to load commit list.
Merged

Resolve some of the plugin check errors and warnings #2772

WP functions are not available in scripts
b371832
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 1s

67.2% (+0.6%) compared to f88648c

View this Pull Request on Codecov

67.2% (+0.6%) compared to f88648c

Details

Codecov Report

Attention: Patch coverage is 76.74419% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.2%. Comparing base (f88648c) to head (b371832).

Files with missing lines Patch % Lines
src/DB/Table/ShippingRateTable.php 0.0% 2 Missing ⚠️
src/API/Google/Connection.php 0.0% 1 Missing ⚠️
src/Assets/ScriptAsset.php 0.0% 1 Missing ⚠️
src/ConnectionTest.php 0.0% 1 Missing ⚠️
src/Coupon/CouponSyncer.php 85.7% 1 Missing ⚠️
src/DB/Migration/Migration20211228T1640692399.php 0.0% 1 Missing ⚠️
src/DB/Query/ShippingRateQuery.php 0.0% 1 Missing ⚠️
src/Jobs/ActionSchedulerJobMonitor.php 0.0% 1 Missing ⚠️
...Jobs/Notifications/AbstractItemNotificationJob.php 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2772      +/-   ##
============================================
+ Coverage       66.7%   67.2%    +0.6%     
- Complexity         0    4677    +4677     
============================================
  Files            316     480     +164     
  Lines           4922   19571   +14649     
  Branches        1204       0    -1204     
============================================
+ Hits            3282   13159    +9877     
- Misses          1503    6412    +4909     
+ Partials         137       0     -137     
Files with missing lines Coverage Δ
google-listings-and-ads.php 75.0% <ø> (ø)
src/API/Google/AdsConversionAction.php 97.6% <100.0%> (ø)
src/API/Google/Middleware.php 95.7% <100.0%> (ø)
src/API/WP/NotificationsService.php 95.5% <100.0%> (ø)
src/DB/Table/AttributeMappingRulesTable.php 46.7% <100.0%> (ø)
src/DB/Table/BudgetRecommendationTable.php 96.4% <100.0%> (ø)
src/DB/Table/MerchantIssueTable.php 40.0% <100.0%> (ø)
src/DB/Table/ShippingTimeTable.php 50.0% <100.0%> (ø)
src/MerchantCenter/MerchantStatuses.php 76.2% <100.0%> (ø)
src/Notes/LeaveReviewActionTrait.php 100.0% <100.0%> (ø)
... and 14 more

... and 772 files with indirect coverage changes