Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomic option locking #967

Merged
merged 8 commits into from
Jul 11, 2023
Merged

Atomic option locking #967

merged 8 commits into from
Jul 11, 2023

Commits on Jun 29, 2023

  1. Describe how option locks should handle possible concurrent claims.

    @barryhughes
    barryhughes committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b5c21ec View commit details
    Browse the repository at this point in the history

  2. Update Option Lock implementation to reduce potential for race condit… 

    …ions.
    @barryhughes
    barryhughes committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    636e298 View commit details
    Browse the repository at this point in the history

  3. Check that lock was set, before proceeding to dispatch async request. 

    Note that we still check is_locked() because, although the option lock implementation has been updated in such a way that we can rely on just calling set(), we do not know that that is the active implementation.
    @barryhughes
    barryhughes committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    d1a5342 View commit details
    Browse the repository at this point in the history

  4. Add guidance for concrete lock::set implementations.

    @barryhughes
    barryhughes committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    530baa1 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Be efficient! Be lazy in terms of creating the lock option.

    @barryhughes
    barryhughes committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    895e8d0 View commit details
    Browse the repository at this point in the history

  2. Unquote column names.

    @barryhughes
    barryhughes committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    62f0d33 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Simplify insert, remove explicit check for existing entry. 

    At least as far back as WP 5.2 (the oldest version we support), the option_name column is defined as unique: therefore we can rely on MySQL to avoid duplicates. Of course, if the schema has been modified and the unique constraint removed, that would be problematic -- but it seems reasonable for us to assume that isn't the case.
    @barryhughes
    barryhughes committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b215f72 View commit details
    Browse the repository at this point in the history

  2. Cleanup.

    @barryhughes
    barryhughes committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    bd2d81a View commit details
    Browse the repository at this point in the history