Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set option value to no rather than deleting #1086

Open
wants to merge 22 commits into
base: trunk
Choose a base branch
from

Conversation

crstauf
Copy link
Contributor

@crstauf crstauf commented Aug 13, 2024

I’m tuning my page load performance. I’ve noticed that on every page there is an individual call to get_option for as_has_wp_comment_logs – rather than this option being loaded as part of wp_load_alloptions.

I think the problem is that, by default, there is no entry in the database options table for as_has_wp_comment_logs so it cannot be autoloaded. If there was an entry in the options table for as_has_wp_comment_logs with value “no” and autoload=yes, I think that would improve page load performance for most people using your plugin.

https://wordpress.org/support/topic/as_has_wp_comment_logs-loading/

@barryhughes barryhughes requested review from a team and coreymckrill and removed request for a team August 13, 2024 23:03
crstauf and others added 3 commits September 6, 2024 08:16
Co-authored-by: Corey McKrill <[email protected]>
Co-authored-by: Corey McKrill <[email protected]>
@crstauf
Copy link
Contributor Author

crstauf commented Oct 3, 2024

@barryhughes Recently #1106, a small PR, was merged into trunk. This too is a small PR. What can I do to get preferential attention? Apparently @coreymckrill has disappeared, and his PR to add unit tests fails because of #1094.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants