Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch size should be adjustable during processing #1078

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Batch size should be adjustable during processing #1078

merged 3 commits into from
Aug 21, 2024

Conversation

crstauf
Copy link
Contributor

@crstauf crstauf commented Aug 1, 2024

Closes #1037.

@barryhughes barryhughes requested review from a team and vedanshujain and removed request for a team August 13, 2024 23:02
vedanshujain
vedanshujain approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@vedanshujain vedanshujain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested by overwriting to 1 and working as expected. I don't see any concerns for existing usage by this change.

Screenshot 2024-08-21 at 5 37 51 PM

@vedanshujain vedanshujain merged commit 6953ec1 into woocommerce:trunk Aug 21, 2024
46 checks passed
@crstauf crstauf deleted the fix-1037 branch August 21, 2024 14:19
@barryhughes barryhughes added this to the 3.8.2 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedanshujain vedanshujain vedanshujain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.2
Development

Successfully merging this pull request may close these issues.

Batch size should be adjustable during processing
3 participants
@crstauf @vedanshujain @barryhughes