has_pending_actions_due() performance improvements
#1077
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barryhughes
requested review from
a team and
coreymckrill
and removed request for
a team
# Conflicts: # classes/abstracts/ActionScheduler_Store.php
There was a problem hiding this comment.
Thanks for the PR @crstauf !
I'm trying to think of the best way to test if has_pending_actions_due() still works as expected with these changes. Any ideas?
At time of creation, does not include 'claimed' => true: unclear if this is appropriate or not.
We discussed this a bit more and decided it's probably better to not include this right now, so this is fine.
@coreymckrill Kinda surprised that there are no unit tests for it, but looking at it, the changes would not impact the result, only the performance. |
coreymckrill
added a commit
that referenced
this pull request
Aug 24, 2024
In #1077 we're making some performance improvements to the `has_pending_actions_due` method, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.
barryhughes
pushed a commit
that referenced
this pull request
Sep 4, 2024
In #1077 we're making some performance improvements to the `has_pending_actions_due` method, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.
coreymckrill
added a commit
that referenced
this pull request
Sep 5, 2024
In #1077 we're making some performance improvements to the `has_pending_actions_due` method, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1036.
At time of creation, does not include
'claimed' => true: unclear if this is appropriate or not.