WP-CLI #1071
WP-CLI #1071
Conversation
barryhughes
requested review from
a team and
vedanshujain
and removed request for
a team
classes/WP_CLI/Action/Cancel.php
Outdated
| try { | ||
| call_user_func( $function_name, $hook, $callback_args, $group ); | ||
| } catch ( \Exception $e ) { | ||
| $this->print_error( $e, $multiple ); |
There was a problem hiding this comment.
note that it won't throw an exception necessarily even if cancelling failed, there could be an error caught by the try_catch in as_unschedule_action. It would be more reliable to either
- check the logs for failed action, or
- verify that the action is indeed cancelled, or
- modify the
as_unschedule_actionto return the result value so that we can display it reliably.
There was a problem hiding this comment.
Going to rework this command a bit: realized in its current state actions could not be unscheduled by group only.
|
The code looks good, going to test around these flows in general:
|
|
@barryhughes Stalled again. 😞 |
|
Yep, I'm sorry. We've been focusing on other tasks and responsibilities that have taken priority. This is looking great, though, so bear with us a little longer. Probably, if any further changes are needed, they'll be minor/small pieces of clean-up, and so we can likely take care of those if required (and can similarly update the branch if it falls out of sync in the meantime). |
Port of crstauf/action-scheduler-cli into Action Scheduler.
Closes #255.
Hope I'm not disappointed.