Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quest step modal update #2246

Open
wants to merge 16 commits into
base: staging
Choose a base branch
from
Open

Quest step modal update #2246

wants to merge 16 commits into from

Conversation

juniusfree
Copy link
Collaborator

@juniusfree juniusfree commented Apr 4, 2024 •
edited
Loading

📌 References

  • Wonder issue:
  • Related pull-requests:

📘 Description

🎥 Screenshot or Video

no custom steps

image

with custom steps

https://www.loom.com/share/5699190e60664dee8b0e4c0fe9e3a7e1

image

🍰 Checklist:

@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wonderverse-web ❌ Failed (Inspect) Apr 8, 2024 9:25am
wondrous-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 9:25am
wondrous-bot-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 9:25am

@juniusfree juniusfree self-assigned this Apr 4, 2024
@juniusfree juniusfree marked this pull request as ready for review April 4, 2024 08:54
Lamperoyge
Lamperoyge reviewed Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@Lamperoyge Lamperoyge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR 🙏 left few comments, also the build is failing for wondrous-bot-admin due to some missing Icon svg

oh and need to change target branch from master to staging

wondrous-bot-admin/src/components/AddFormEntity/index.tsx Show resolved Hide resolved
wondrous-bot-admin/src/components/CreateTemplate/index.tsx Outdated Show resolved Hide resolved
...dmin/src/components/AddFormEntity/components/ComponentOptionsModal/ComponentOptionsModal.tsx Outdated Show resolved Hide resolved
...dmin/src/components/AddFormEntity/components/ComponentOptionsModal/ComponentOptionsModal.tsx Outdated Show resolved Hide resolved
wondrous-bot-admin/src/components/AddFormEntity/constants.ts Outdated Show resolved Hide resolved
wondrous-bot-admin/src/components/AddFormEntity/index.tsx Outdated Show resolved Hide resolved
@juniusfree juniusfree changed the base branch from master to staging April 8, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andywong418 andywong418 Awaiting requested review from andywong418

@Lamperoyge Lamperoyge Awaiting requested review from Lamperoyge

At least 1 approving review is required to merge this pull request.

Assignees

@juniusfree juniusfree

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juniusfree @Lamperoyge