Don't overwrite save file on failed JSON serialization, fixes file corruption problem #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this because sometimes the
saveData
had something that wasn't able to be serialized and it would corrupt the save file when runningjson.dump()
. This change creates a temp file with adatetime
that is used to test whether the json serialization will succeed. This change will output a runtime error to let the user know if there is a problem and won't break the save file. On failure, the original save before the changes is maintained.Let me know if there is anything else I can do to support this PR or if you need more info.