use self hosted wolfi runners for pre/postsubmit builds #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
requested review from
tcnghia and
imjasonh
and removed request for
a team
joshrwolf
force-pushed
the
wolfi-runners
branch
26 times, most recently
from
88c5950
to
d15b4b5
Compare
joshrwolf
force-pushed
the
wolfi-runners
branch
5 times, most recently
from
338ccea
to
1886a31
Compare
imjasonh
approved these changes
Aug 30, 2023
joshrwolf
force-pushed
the
wolfi-runners
branch
4 times, most recently
from
9aea899
to
ce737ff
Compare
joshrwolf
force-pushed
the
wolfi-runners
branch
from
ce737ff
to
05e1474
Compare
joshrwolf
commented
Aug 30, 2023
Comment on lines
-8
to
-13
| inputs: | ||
| only: | ||
| description: 'Specific image name to build' | ||
| type: string | ||
| required: false | ||
| default: '' |
There was a problem hiding this comment.
removing this is part laziness of figuring out the magical if: github actions incantation, but also part because these builds are much faster and far more independent now, so it's simpler to just rebuild everything on a trigger
joshrwolf
commented
Aug 30, 2023
Comment on lines
+11
to
+14
| permissions: | ||
| id-token: write | ||
| packages: write | ||
| contents: read |
There was a problem hiding this comment.
I can't actually test that this is WAI until this lands, so I'll monitor this when it lands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors how we build the individual images to better align with our new custom multi arch runners.
previous:
new:
it's a significant refactor, but I think this is easier to follow what's going on