Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play-JSON conversion #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Play-JSON conversion #44

wants to merge 3 commits into from

Conversation

chrisjameswright
Copy link
Collaborator

No description provided.

@wolfendale
Copy link
Owner

Looks good. I think it's worth thinking about the interface and what the expected usage of this would be.

There are two parts to this:

  • The general interface of the main library
  • How we expect people to use the library in a Play project

We don't necessarily need to make sure that these interfaces are the same (as I'd rather that the implementation in this case was more idiomatic to a Play project anyway.) But I think that we should always be considering the fact that in the long run we'd like to make it easy to integrate this with other libraries and frameworks. If nothing else it may dictate some of the internal interfaces too.

Given that we're intending this library to supersede the rhino based one and we may have a few early adoption cases it makes sense to strive for the interface which is used there. Also, if we segregate that interface in the play integration library it lets us change the interface of the main library as needed.

</essay>

@chrisjameswright chrisjameswright marked this pull request as ready for review December 9, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants