Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AITEWIN ROBOT ESP32-C3 SuperMini #28

Merged
merged 14 commits into from
Feb 9, 2024
Merged

AITEWIN ROBOT ESP32-C3 SuperMini #28

merged 14 commits into from
Feb 9, 2024

Conversation

geekgarage
Copy link
Contributor

I added the AITEWIN ROBOT ESP32-C3 SuperMini that's a somewhat clone or derivative of the Adafruit QT Py ESP32-C3

I've tested all IO's and cannot find any faults or improper configuration.

(sorry for redoing PR. The first pin out diagram i found was incorrect so i had to redo all labels in the config, and somehow i managed to delete my existing PR instead of updating it)

Here is the proper Pinout for this seller
https://www.aliexpress.com/item/1005005757810089.html?spm=a2g0o.order_list.order_list_main.87.37ee18028dkcaE
Pinout-Back

geekgarage and others added 5 commits January 27, 2024 18:53
Added AITEWIN ROBOT ESP32-C3 SuperMini
Found out dealing with SPI and I2C that the pin out diagram from seller was incorrect. Found another pin out diagram, tested with those description and they both work now
Missing extra labels on pin 10, 20 and 21
@urish
Copy link
Contributor

urish commented Jan 30, 2024

Thanks for the PR! Sorry for not looking into this earlier, I'm a bit swamped with other stuff. Anyway, I plan to look into it this week and merge if all good

@geekgarage
Copy link
Contributor Author

Thanks for the PR! Sorry for not looking into this earlier, I'm a bit swamped with other stuff. Anyway, I plan to look into it this week and merge if all good

I added some extra files not currently needed in case you think #29 feature request could be something in the long run, then there is some test data to play around with

@urish
Copy link
Contributor

urish commented Jan 31, 2024

Thanks!

Some feedback:

  1. Please replace the "_" with a dash (i.e. aitewin_robot-esp32-c3-supermini
  2. Please change the pin spacing in board.json so it's an exact multiple of 2.54. It's very already very close to a multiple of 2.54, so it's just a minor adjustment of the coordinates, both in the X and Y axes.

Note my comments about the CSV / TXT file in #29.

@geekgarage
Copy link
Contributor Author

Thanks!

Some feedback:

1. Please replace the "_" with a dash (i.e. `aitewin_robot-esp32-c3-supermini`

2. Please change the pin spacing in board.json so it's an exact multiple of 2.54. It's very already very close to a multiple of 2.54, so it's just a minor adjustment of the coordinates, both in the X and Y axes.

Note my comments about the CSV / TXT file in #29.

I've done the following:

  • Removed the two file (CSV and TXT)
  • Renamed the board in the JSON to include manufacturer
  • Added a buy section with how i think it could be done. you can just remove it if it won't play nice or you want it done in another way.
  • Renamed the folder
  • Made sure there is no underscores in files and folders
  • Fixed Pin spacing in X and Y so it's dividable with 2,54mm

@urish
Copy link
Contributor

urish commented Feb 2, 2024

Thank you! I hope to get to review it by Sunday and merge. Will keep you posted

Copy link
Contributor

@urish urish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

boards/aitewinrobot-esp32c3-supermini/board.json Outdated Show resolved Hide resolved
boards/aitewinrobot-esp32c3-supermini/board.json Outdated Show resolved Hide resolved
change version
Temp update led pin name for the onboard GPIO8 LED
Updated the incorrect field regarding onboard GPIO8 LED
SImplifying the pin names as requested for merge into Wokwi.
NOTE: This will make for a worse user experience IMO
@geekgarage geekgarage requested a review from urish February 7, 2024 13:45
@urish urish self-assigned this Feb 7, 2024
@urish urish merged commit bad38c4 into wokwi:main Feb 9, 2024
@urish
Copy link
Contributor

urish commented Feb 9, 2024

Thanks again for contributing this board! It's now available in Wokwi :)

@geekgarage
Copy link
Contributor Author

Thanks again for contributing this board! It's now available in Wokwi :)

Sweet, how would i go about using it then. i tried changing the board to "aitewinrobot-esp32c3-supermini" as that's what it is named but nothing happens. So I'm a bit confused as to how I would go about using it in my projects on Wokwi :P

@urish
Copy link
Contributor

urish commented Feb 9, 2024

Yeah, it should be board-aitewinrobot-esp32c3-supermini. Here's the obligatory blink: https://wokwi.com/projects/389262377969018881

@geekgarage
Copy link
Contributor Author

aaah i forgot the "board-" part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants