-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore of the switch to EOSchemaSynchronizationFactory. Warning: #566
base: master
Are you sure you want to change the base?
Restore of the switch to EOSchemaSynchronizationFactory. Warning: #566
Conversation
… migration can fail with invalid identifier because the column names are not quoted. I searched but cannot find where to fix this problem.
I spend some time trying to figure where to add the quote on the column identifiers in create table statement without success. The table name itself should also be quoted. In KAAccessControlDemo, one of the table fail: CREATE TABLE User(id INTEGER NOT NULL, language VARCHAR(10) NOT NULL, passwordHash VARCHAR(200), username VARCHAR(100) NOT NULL); User is a reserved word, language is also but is OK in this situation but all identifiers should be quoted. The primary key generation miss the quote too: And the foreign Key: But unique index are OK: Not null constraints are not created with specified names, just NOT NULL added to the column definition. |
The _dbupdater created by the migration class is correctly generated and use the EOSchemaSynchronizationFactory. Table created in my migration class does not. CREATE TABLE "_dbupdater" ( "lockowner" VARCHAR(100), "modelname" VARCHAR(100) CONSTRAINT NOT_NULL__dbupdater__modelname NOT NULL, "updatelock" INTEGER CONSTRAINT NOT_NULL__dbupdater__updatelock NOT NULL, "version" INTEGER CONSTRAINT NOT_NULL__dbupdater__version NOT NULL ) |
If this is just a revert of a previous commit, can someone pick this up? I would, but I cannot test any FB stuff. |
Perhaps my new pull request have solved the issues reported here. Please refer to #640 |
By way of update here, #640 was closed without merging, so it won't be helping here. If this affects only |
Unfortunately, we need to solve the conflicts before merging this pull request. 😕 @spelletier is this pull request still relevant to you? Can you update it if it is? We're going to merge it as long as it has no conflicts and somebody has tested it. |
The migration can fail with invalid identifier because the column names are not quoted. I searched but cannot find where to fix this problem.