Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement car-mirror-wasm and car-mirror-axum crates #44

Merged
merged 25 commits into from
Mar 4, 2024

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Mar 1, 2024

TODO:

  • documentation todos in car-mirror-axum

@matheus23 matheus23 self-assigned this Mar 1, 2024
Copy link

socket-security bot commented Mar 1, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@matheus23
Copy link
Member Author

@SocketSecurity ignore npm/[email protected]

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 19.28571% with 226 lines in your changes are missing coverage. Please review.

Project coverage is 42.99%. Comparing base (74eb5dc) to head (f9721b4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   50.85%   42.99%   -7.87%     
==========================================
  Files          15       22       +7     
  Lines         759      935     +176     
  Branches      358      452      +94     
==========================================
+ Hits          386      402      +16     
- Misses         65      190     +125     
- Partials      308      343      +35     
Files Coverage Δ
car-mirror-axum/src/lib.rs 100.00% <100.00%> (ø)
car-mirror-reqwest/src/lib.rs 100.00% <ø> (ø)
car-mirror/src/dag_walk.rs 46.29% <ø> (+3.70%) ⬆️
car-mirror/src/lib.rs 100.00% <ø> (ø)
car-mirror/src/messages.rs 83.33% <75.00%> (-16.67%) ⬇️
car-mirror/src/common.rs 52.76% <62.50%> (-1.25%) ⬇️
car-mirror/src/serde_cid_vec.rs 36.36% <36.36%> (ø)
car-mirror-reqwest/src/request.rs 50.81% <15.78%> (-3.42%) ⬇️
car-mirror/src/serde_bloom_bytes.rs 20.00% <20.00%> (ø)
car-mirror-reqwest/tests/integration.rs 0.00% <0.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

@matheus23
Copy link
Member Author

Improving coverage at this point is getting hard 😐
image

@matheus23
Copy link
Member Author

@SocketSecurity ignore npm/[email protected]

@matheus23 matheus23 merged commit 0ca6f34 into main Mar 4, 2024
10 of 12 checks passed
@matheus23 matheus23 deleted the matheus23/car-mirror-wasm branch March 4, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant