Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Take impl BlockStore instead of &impl BlockStore in general #40

Merged
merged 9 commits into from
Feb 15, 2024

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Feb 13, 2024

Also:

  • Remove async_trait
  • Expose blanket impl<C: Cache> Cache for &C and Box<C>
  • Move the trait module to cache
  • Remove has_block from trait Cache
  • Add a blockstore wrapper utility CacheMissing under the quick_cache feature

@matheus23 matheus23 self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (3067020) 48.39% compared to head (0b024ff) 53.13%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   48.39%   53.13%   +4.73%     
==========================================
  Files          12       12              
  Lines         560      559       -1     
  Branches      268      249      -19     
==========================================
+ Hits          271      297      +26     
+ Misses         69       59      -10     
+ Partials      220      203      -17     
Files Coverage Δ
car-mirror/src/lib.rs 100.00% <ø> (ø)
car-mirror/src/pull.rs 68.42% <100.00%> (ø)
car-mirror/src/push.rs 68.42% <100.00%> (ø)
car-mirror/src/test_utils/local_utils.rs 43.90% <0.00%> (+1.40%) ⬆️
car-mirror/src/incremental_verification.rs 53.57% <44.44%> (+7.57%) ⬆️
car-mirror/src/common.rs 56.54% <45.00%> (+2.73%) ⬆️
car-mirror/src/dag_walk.rs 42.59% <43.33%> (+3.56%) ⬆️
car-mirror/src/cache.rs 58.33% <58.33%> (ø)

... and 1 file with indirect coverage changes

@matheus23 matheus23 marked this pull request as ready for review February 15, 2024 18:55
@matheus23 matheus23 merged commit 370fd83 into main Feb 15, 2024
11 checks passed
@matheus23 matheus23 deleted the matheus23/traits-refactor branch February 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant