feat: Implement half-duplex streaming #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 49.70% 50.00% +0.29%
==========================================
Files 13 13
Lines 511 560 +49
Branches 244 267 +23
==========================================
+ Hits 254 280 +26
- Misses 60 62 +2
- Partials 197 218 +21
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements streaming the CAR file that's generated in a response and consuming a response CAR stream.
This is not doing full-duplex streaming yet, but the difference shouldn't be too big.
This has helped cold sync in appa a lot, since it reduces the amount of round-trips to one and streams all bytes needed for sync in one go.