Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly handle raw-codec CIDs/blocks #37

Merged
merged 15 commits into from
Jan 2, 2024
Merged

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Dec 28, 2023

Major things in this PR:

  • Correctly handle raw-codec CIDs/blocks, they were previously not transferred due to a bug in IncrementalDagVerification.
  • Update wnfs-common to 0.1.26 so this crate is compatible with the latest rs-wnfs.
  • Introduce another cache, a positive cache for checking if we already have a block. (Work on Performance: Implement Caching #28)
  • Make sure the main request/response futures are Send

@matheus23 matheus23 self-assigned this Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (cb57d41) 48.60% compared to head (8d0c5c0) 49.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   48.60%   49.51%   +0.90%     
==========================================
  Files          13       13              
  Lines         467      511      +44     
  Branches      216      244      +28     
==========================================
+ Hits          227      253      +26     
+ Misses         65       60       -5     
- Partials      175      198      +23     
Files Coverage Δ
car-mirror/src/lib.rs 100.00% <ø> (ø)
car-mirror/src/pull.rs 68.42% <ø> (ø)
car-mirror/src/push.rs 68.42% <ø> (ø)
car-mirror/src/test_utils/local_utils.rs 42.50% <ø> (ø)
car-mirror/src/test_utils/blockstore_utils.rs 35.71% <0.00%> (-2.75%) ⬇️
car-mirror/src/common.rs 58.63% <54.54%> (+1.26%) ⬆️
car-mirror/src/test_utils/dag_strategy.rs 42.30% <68.75%> (+8.97%) ⬆️
car-mirror/src/incremental_verification.rs 43.20% <35.00%> (+1.67%) ⬆️
car-mirror/src/traits.rs 26.31% <23.07%> (+4.57%) ⬆️

@matheus23 matheus23 changed the title chore: Update wnfs-common to 0.1.26 fix: Correctly handle raw-codec CIDs/blocks Jan 2, 2024
@matheus23 matheus23 merged commit b22fb94 into main Jan 2, 2024
10 of 11 checks passed
@matheus23 matheus23 deleted the matheus23/upgrade-wnfs branch January 2, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant