Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tool to query OSCAR to support station management (#469) #504

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

tomkralidis
Copy link
Collaborator

Implements #469

Copy link
Collaborator

@maaikelimper maaikelimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get-function described itself as "Publishes collection of stations to API config and backend". The current implementation only prints a line.
Should the get-function update the station_list.csv (our current backend) ?
Or we write in the documentation that the user has to take care of getting the line in the csv :
wis2box metadata station get -wsi 0-20000-01515 >> /data/wis2box/metadata/station_list.csv

@tomkralidis
Copy link
Collaborator Author

I've fixed the docstring accordingly. We should keep the shell redirection option which gives the user the ability to review before potentially adding to the station list.

@maaikelimper maaikelimper self-requested a review September 5, 2023 11:11
@tomkralidis tomkralidis merged commit becde08 into main Sep 5, 2023
3 checks passed
@tomkralidis tomkralidis deleted the issue-469-pyoscar branch September 5, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants