Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge templates #118

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Merge templates #118

merged 5 commits into from
Sep 5, 2023

Conversation

david-i-berry
Copy link
Member

Merge of csv2bufr_templates and csv2bufr modules.

  • Templates can now be loaded with csv2bufr.templates.load_template()
  • Default templates provided
  • User defined path for templates added (CSV2BUFR_TEMPLATES=...)

@david-i-berry
Copy link
Member Author

@tomkralidis @maaikelimper I've refactored where the default templates are in the module. I don't know if these are used in the wis2box but something to be aware off when reviewing.

csv2bufr/templates/__init__.py Outdated Show resolved Hide resolved
csv2bufr/templates/__init__.py Outdated Show resolved Hide resolved
csv2bufr/templates/__init__.py Outdated Show resolved Hide resolved
csv2bufr/templates/__init__.py Outdated Show resolved Hide resolved
csv2bufr/templates/__init__.py Outdated Show resolved Hide resolved
csv2bufr/templates/__init__.py Outdated Show resolved Hide resolved
csv2bufr/templates/__init__.py Outdated Show resolved Hide resolved
csv2bufr/templates/__init__.py Outdated Show resolved Hide resolved
@tomkralidis
Copy link
Collaborator

Thanks @david-i-berry. To confirm, https://github.com/wmo-im/csv2bufr-templates is now not to be used? Should this repo be set to archived mode then?

@david-i-berry
Copy link
Member Author

Thanks @david-i-berry. To confirm, https://github.com/wmo-im/csv2bufr-templates is now not to be used? Should this repo be set to archived mode then?

Yes, I'll mark it to archived now and add a note.

@tomkralidis tomkralidis merged commit 4a5cdae into main Sep 5, 2023
6 checks passed
@tomkralidis tomkralidis deleted the merge-templates branch September 5, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants