Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup 1.40 test fragility #648

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Cleanup 1.40 test fragility #648

merged 2 commits into from
Apr 16, 2024

Conversation

RickiJay-WMDE
Copy link
Member

@RickiJay-WMDE RickiJay-WMDE commented Apr 15, 2024 •
edited
Loading

Using () => {} instead of function () {} for tests means the context is incorrect, so things like this.retries() don't work.

We made this change to main a while ago - it never got down to mw-1.40

@RickiJay-WMDE RickiJay-WMDE marked this pull request as ready for review April 15, 2024 08:56
@RickiJay-WMDE RickiJay-WMDE requested a review from a team April 15, 2024 08:56
@RickiJay-WMDE RickiJay-WMDE requested a review from a team April 15, 2024 09:00
lorenjohnson
lorenjohnson approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny. I am surprised this never made it to the mw1.40 branch. I thought at the time we fixed this that we were backporting most everything. Evidently not...

@RickiJay-WMDE RickiJay-WMDE merged commit d18df4b into mw-1.40 Apr 16, 2024
28 checks passed
@RickiJay-WMDE RickiJay-WMDE deleted the cleanup-1.40-test-fragility branch April 16, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rti rti rti approved these changes

@lorenjohnson lorenjohnson lorenjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RickiJay-WMDE @lorenjohnson @rti