Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update javascript dependencies #778

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

yerdua
Copy link
Contributor

@yerdua yerdua commented Oct 11, 2024

Included updates:
typescript 5.5.4 -> 5.6.3

  • disallows nullish and truthy checks
  • introduces iterator helper methods
  • adds support for arbitrary module identifiers
  • new options: --noUncheckedSideEffectImports and --noCheck
  • allows --build with intermediate errors

@types/jest, @types/lodash

  • patch update

eslint-plugin-cypress 3.5.0 -> 3.6.0

  • notifies about eslint 8 deprecation

eslint-plugin-vue 9.27.0 -> 9.28.0

  • allows specifying custom macros
  • added additionalDirectives to vue/require-toggle-inside-transition
  • various bugfixes

sass 1.77.8 -> 1.79.4

  • color functions interpret numbers with % as a percentage
  • no longer rounds RGB channels to the nearest integer, matching latest CSS spec
  • add support for CSS Color Level 4 color spaces
  • rgb colors can have non-integer channels and channels outside normal gamut of 0-255
  • adds new functions for working with color spaces

vite-plugin-banner 0.7.1 -> 0.8.0

  • bugfixes

@namics/stylelint-bem 10.0.0 -> 10.0.1

  • update dependency postcss-resolve-nested-selector

start-server-and-test 2.0.5 -> 2.0.8

  • update dependencies

@vue/compiler-dom 3.4.27 -> 3.5.12

  • bugfixes and performance improvements

@wikimedia/codex
@wikimedia/codex-design-tokens 1.12.0 -> 1.13.1

  • MenuItem: multiselect check icon (lwatson)
  • Lookup: Only clear selection on input if there is one (Anne Tomasevich)
  • Radio: Add error handling (Volker E)
  • tokens: Expand color palette (Derek Torsani)
  • Message: Prevent content from being wider than the container (Bartosz Dziewoński)
  • Thumbnail: set background color for visibility in dark mode (lwatson)

Bug: T376259

@yerdua yerdua force-pushed the update-dependencies-20241010 branch from 157e366 to 9cab075 Compare October 11, 2024 15:05
@codders
Copy link
Contributor

codders commented Oct 14, 2024

Looks great. Please put a bug link in the PR comment and commit comment, and drop a link to the PR in phabricator so that we can see what the related change is.

@yerdua yerdua force-pushed the update-dependencies-20241010 branch from 9cab075 to 319ec6c Compare October 14, 2024 08:49
Copy link
Contributor

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good. I notice, though, that the package-lock.json has been updated for all packages, whereas the package.json only has updates for a couple. Can you make package.json match the versions in the lockfile?

Included updates:
typescript 5.5.4 -> 5.6.3
  - disallows nullish and truthy checks
  - introduces iterator helper methods
  - adds support for arbitrary module identifiers
  - new options: `--noUncheckedSideEffectImports` and `--noCheck`
  - allows `--build` with intermediate errors

@types/jest, @types/lodash
  - patch update

eslint-plugin-cypress  3.5.0 -> 3.6.0
  - notifies about eslint 8 deprecation

eslint-plugin-vue 9.27.0 -> 9.28.0
  - allows specifying custom macros
  - added `additionalDirectives` to `vue/require-toggle-inside-transition`
  - various bugfixes

sass  1.77.8 -> 1.79.5
  - color functions interpret numbers with `%` as a percentage
  - no longer rounds RGB channels to the nearest integer, matching
    latest CSS spec
  - add support for CSS Color Level 4 color spaces
  - rgb colors can have non-integer channels and channels outside
    normal gamut of 0-255
  - adds new functions for working with color spaces

vite-plugin-banner  0.7.1 -> 0.8.0
  - bugfixes

@namics/stylelint-bem  10.0.0 -> 10.0.1
  - update dependency postcss-resolve-nested-selector

start-server-and-test  2.0.5 -> 2.0.8
  - update dependencies

@vue/compiler-dom     3.4.27 -> 3.5.12
  - bugfixes and performance improvements

@wikimedia/codex
@wikimedia/codex-design-tokens  1.12.0 -> 1.13.1
  - MenuItem: multiselect check icon (lwatson)
  - Lookup: Only clear selection on input if there is one (Anne Tomasevich)
  - Radio: Add error handling (Volker E)
  - tokens: Expand color palette (Derek Torsani)
  - Message: Prevent content from being wider than the container (Bartosz Dziewoński)
  - Thumbnail: set background color for visibility in dark mode (lwatson)

Bug: T376259
@yerdua yerdua force-pushed the update-dependencies-20241010 branch from 319ec6c to 1fa7a9a Compare October 14, 2024 09:44
@yerdua
Copy link
Contributor Author

yerdua commented Oct 14, 2024

thanks for catching that! I think I did it right this time.

@codders
Copy link
Contributor

codders commented Oct 14, 2024

Looks great - thank you!

@codders codders merged commit 4d91a4e into main Oct 14, 2024
2 checks passed
@codders codders deleted the update-dependencies-20241010 branch October 14, 2024 10:03
lucaswerkmeister added a commit that referenced this pull request Oct 16, 2024
This effectively reverts #774 (commit 0656354) and part of #778
(commit 4d91a4e) – we want to stay on the same Vue version as
MediaWiki core (see README).
yerdua pushed a commit that referenced this pull request Oct 17, 2024
* Restore @vue/compiler-dom to 3.4.27

This effectively reverts #774 (commit 0656354) and part of #778
(commit 4d91a4e) – we want to stay on the same Vue version as
MediaWiki core (see README).

* Remove Vue updates from Dependabot

Per the README, we want to keep using the same Vue version as MediaWiki
core, so let’s disable Dependabot updates for these packages.

* Pin Vue versions in package.json

Since we want these versions to be exact, let’s not use the caret
operator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants