-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update javascript dependencies #778
Conversation
157e366
to
9cab075
Compare
Looks great. Please put a bug link in the PR comment and commit comment, and drop a link to the PR in phabricator so that we can see what the related change is. |
9cab075
to
319ec6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look good. I notice, though, that the package-lock.json has been updated for all packages, whereas the package.json only has updates for a couple. Can you make package.json match the versions in the lockfile?
Included updates: typescript 5.5.4 -> 5.6.3 - disallows nullish and truthy checks - introduces iterator helper methods - adds support for arbitrary module identifiers - new options: `--noUncheckedSideEffectImports` and `--noCheck` - allows `--build` with intermediate errors @types/jest, @types/lodash - patch update eslint-plugin-cypress 3.5.0 -> 3.6.0 - notifies about eslint 8 deprecation eslint-plugin-vue 9.27.0 -> 9.28.0 - allows specifying custom macros - added `additionalDirectives` to `vue/require-toggle-inside-transition` - various bugfixes sass 1.77.8 -> 1.79.5 - color functions interpret numbers with `%` as a percentage - no longer rounds RGB channels to the nearest integer, matching latest CSS spec - add support for CSS Color Level 4 color spaces - rgb colors can have non-integer channels and channels outside normal gamut of 0-255 - adds new functions for working with color spaces vite-plugin-banner 0.7.1 -> 0.8.0 - bugfixes @namics/stylelint-bem 10.0.0 -> 10.0.1 - update dependency postcss-resolve-nested-selector start-server-and-test 2.0.5 -> 2.0.8 - update dependencies @vue/compiler-dom 3.4.27 -> 3.5.12 - bugfixes and performance improvements @wikimedia/codex @wikimedia/codex-design-tokens 1.12.0 -> 1.13.1 - MenuItem: multiselect check icon (lwatson) - Lookup: Only clear selection on input if there is one (Anne Tomasevich) - Radio: Add error handling (Volker E) - tokens: Expand color palette (Derek Torsani) - Message: Prevent content from being wider than the container (Bartosz Dziewoński) - Thumbnail: set background color for visibility in dark mode (lwatson) Bug: T376259
319ec6c
to
1fa7a9a
Compare
thanks for catching that! I think I did it right this time. |
Looks great - thank you! |
* Restore @vue/compiler-dom to 3.4.27 This effectively reverts #774 (commit 0656354) and part of #778 (commit 4d91a4e) – we want to stay on the same Vue version as MediaWiki core (see README). * Remove Vue updates from Dependabot Per the README, we want to keep using the same Vue version as MediaWiki core, so let’s disable Dependabot updates for these packages. * Pin Vue versions in package.json Since we want these versions to be exact, let’s not use the caret operator.
Included updates:
typescript 5.5.4 -> 5.6.3
--noUncheckedSideEffectImports
and--noCheck
--build
with intermediate errors@types/jest, @types/lodash
eslint-plugin-cypress 3.5.0 -> 3.6.0
eslint-plugin-vue 9.27.0 -> 9.28.0
additionalDirectives
tovue/require-toggle-inside-transition
sass 1.77.8 -> 1.79.4
%
as a percentagevite-plugin-banner 0.7.1 -> 0.8.0
@namics/stylelint-bem 10.0.0 -> 10.0.1
start-server-and-test 2.0.5 -> 2.0.8
@vue/compiler-dom 3.4.27 -> 3.5.12
@wikimedia/codex
@wikimedia/codex-design-tokens 1.12.0 -> 1.13.1
Bug: T376259