Use ByPropertyIdGrouper in Claims #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,10 @@ | |||
| * Added `ByPropertyIdGrouper` | |||
| * Added `BestStatementsFinder` | |||
|
|
|||
| #### Deprecations | |||
|
|
|||
| * Deprecated `ByPropertyIdArray` in favour of `ByPropertyIdGrouper` | |||
There was a problem hiding this comment.
ByPropertyIdArray has all this moving stuff, which ByPropertyIdGrouper does not have. Unfortunately that stuff is needed. If it was not, we'd just be able to kill it and stick with a sane ByPropertyIdArray.
Removed the deprecation and started a rewrite of |
Benestar
changed the title
| return new self(); | ||
| } | ||
|
|
||
| return new self( $claimsByProp->getByPropertyId( $propertyId ) ); | ||
| return new self( $byPropertyIdGrouper->getByPropertyId( $propertyId ) ); |
There was a problem hiding this comment.
This is less readable than before
JeroenDeDauw
added a commit
that referenced
this pull request
Sep 27, 2014
Use ByPropertyIdGrouper in Claims
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.