is_instructional is useful again! #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltering parameters
JasonLovesDoggo
requested changes
Oct 10, 2024
| schedule_formats = settings.TIMETABLE_FORMATS[self.term.timetable_format][ | ||
| "schedules" | ||
| ] | ||
| self.is_instructional = len(schedule_formats[self.schedule_format]) > 0 |
There was a problem hiding this comment.
Don't love this implementation, could be more explicit but it'll pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#280
not a deprecation: is_instructional still exists, it just isn't editable by hand (automatically assigned when the model is saved), this is because it's easier to just store the boolean to later use it for determining a day's schedule
did not rename is_instructional to avoid making migrations but i cleaned up the help text a bit so hopefully its more clear
added 2 timetable formats (pa-day, holiday). they are empty and currently functionally identical
also various other small misc changes related to the calendar/events