Remove attempt to POST request download of cling ROOT tarball #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know how that came to be; code is ancient, always seems to have worked. :) Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the original intent here was, but the docs for both python 2 (https://docs.python.org/2/library/urllib2.html#urllib2.urlopen) and urllib.request for python 3 (https://docs.python.org/3.8/library/urllib.request.html#urllib.request.urlopen) both show the second parameter here as being for the data that is used in a POST request or similar.
The ROOT server isn't configured to allow POST requests to download the file, and so responds with a 405.
$ curl -I -X GET https://root.cern.ch/download/root_v6.32.08.source.tar.gz
HTTP/1.1 200 OK
...
$ curl -I -X POST https://root.cern.ch/download/root_v6.32.08.source.tar.gz
HTTP/1.1 405 Method Not Allowed
...