ClusterReader Fine Grained Access Control #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClusterReader RBAC Role should provide minimal permissions. Also enable end-users to decide via Values whether to enable verb list on k8s secrets.
|
Hey @avo-sepp, When are you planning to merge this PR? I am looking forward to this feature. |
I am waiting on the Wiz team to review the PR. I cannot merge it. |
|
This would address this issue I opened: Pinging my Wiz contacts to see if traction can be gained here- as it is undesirable to have to hack around the wildcard permissions and inclusion of |
Dan-Rediske
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Seems right per https://docs.wiz.io/wiz-docs/docs/kubernetes-req-perm-api?lng=en
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this commit is to allow end users to opt out of
list secretsusing the values file. Instead of having to write a new version of the Cluster Reader role. Because permissions are additive, the commit must first break out the*glob permission. Then add a section where the list secret can be enabled with a values boolean. The new boolean is underclusterReader.enableListSecrets.This is cleaner than expecting users to fork the chart or maintain their own RBAC permissions.