Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typescript): use node16 moduleResolution #2972

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

AviVahl
Copy link
Collaborator

@AviVahl AviVahl commented Aug 28, 2024

added missing project references
worked around vlq having no "types" inside its "exports"

@AviVahl AviVahl requested a review from idoros August 28, 2024 12:28
@AviVahl AviVahl force-pushed the avi/use-node16-module-resolution branch 2 times, most recently from 9fc9d08 to 4994f56 Compare August 28, 2024 12:36
@AviVahl AviVahl requested a review from barak007 August 29, 2024 10:30
@AviVahl AviVahl force-pushed the avi/use-node16-module-resolution branch 3 times, most recently from e1485b8 to 57e879b Compare August 31, 2024 22:15
@AviVahl
Copy link
Collaborator Author

AviVahl commented Aug 31, 2024

Need to validate that create-stylable-app's import of definition file works.

EDIT: fixed

@AviVahl AviVahl force-pushed the avi/use-node16-module-resolution branch 5 times, most recently from e6f9329 to f26784f Compare September 6, 2024 11:36
@AviVahl AviVahl force-pushed the avi/use-node16-module-resolution branch 3 times, most recently from 7da0cd6 to 3de476a Compare September 13, 2024 00:12
@AviVahl AviVahl force-pushed the avi/use-node16-module-resolution branch 2 times, most recently from 28d12ec to 7cc817c Compare November 2, 2024 12:13
added missing project references
worked around vlq having no "types" inside its "exports"
@AviVahl AviVahl force-pushed the avi/use-node16-module-resolution branch from 7cc817c to bd5aaeb Compare November 3, 2024 09:54
@AviVahl AviVahl merged commit 7b2bf99 into master Nov 5, 2024
13 checks passed
@AviVahl AviVahl deleted the avi/use-node16-module-resolution branch November 5, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants