Native lib reorder #3750
Open
Native lib reorder #3750
+45
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Jun 8, 2025
lib/components/HighlighterOverlay/HighlighterOverlayView.web.tsx
Outdated
Show resolved
Hide resolved
| @@ -2,6 +2,7 @@ | |||
| "name": "KeyboardAccessoryView", | |||
| "category": "infra", | |||
| "description": "View that allows replacing the default keyboard with other components", | |||
| "note": "This view is useful only for iOS", | |||
There was a problem hiding this comment.
This is used in Android as well
There was a problem hiding this comment.
Yes. See component description
There was a problem hiding this comment.
This is KeyboardAccessoryView it is not only for iOS.
lib/components/Keyboard/KeyboardTrackingView/keyboardTrackingView.api.json
Show resolved
Hide resolved
M-i-k-e-l
reviewed
Jun 9, 2025
There was a problem hiding this comment.
There's no need for a folder + index, it can be simplified to KeyboardUtils.ts
| @@ -2,6 +2,7 @@ | |||
| "name": "KeyboardAccessoryView", | |||
| "category": "infra", | |||
| "description": "View that allows replacing the default keyboard with other components", | |||
| "note": "This view is useful only for iOS", | |||
There was a problem hiding this comment.
This is KeyboardAccessoryView it is not only for iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Native lib reorder + bump version to 5.0.0
Changelog
Native lib reorder + bump version to 5.0.0
Additional info
RN77 new arc