Picker - migrate prop deprecation end #3737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
May 25, 2025
There was a problem hiding this comment.
@adids1221 please add docs to https://wix.github.io/react-native-ui-lib/docs/getting-started/v8
|
@M-i-k-e-l you assigned me without any comment ? |
M-i-k-e-l
reviewed
Jun 4, 2025
docs/getting-started/v8.md
Outdated
| @@ -73,3 +73,6 @@ Removed (use `PanView` instead) | |||
| Use the `backgroundColor` prop instead of `contentContainerStyle={{backgroundColor}}` | |||
| Fix card being transparent on Android | |||
| `onCollapseChanged` will now be called after the animation has ended (as was intended) | |||
|
|
|||
| ### Picker | |||
| Removed `migrate` prop - the picker now only supports the new value format (direct values instead of `{value, label}` objects). | |||
There was a problem hiding this comment.
Let's improve this, see my PM
It was pending, look at the PM and improve the docs please |
…Picker components
…recated props and updating value handling
…fy label handling
M-i-k-e-l
reviewed
Jun 10, 2025
docs/getting-started/v8.md
Outdated
| The component was refactored to simplify its API and improve type safety. | ||
|
|
||
| Props migration: | ||
| - `migrate` - Removed (new API is default) |
There was a problem hiding this comment.
Suggested change
| - `migrate` - Removed (new API is default) | |
| - `migrate` - Removed |
There is no old API so there is no default - there is only one API
docs/getting-started/v8.md
Outdated
Comment on lines
82
to
83
| - `getItemValue` - Removed (value extraction is now automatic from `item.value`) | ||
| - `getItemLabel` - Removed (label extraction is now automatic from `item.label`) |
There was a problem hiding this comment.
Maybe: "Use item.<X> to get <X>"
M-i-k-e-l
reviewed
Jun 10, 2025
Comment on lines
+91
to
+92
| - `getItemValue` - Removed (use `item.value` to get value) |
There was a problem hiding this comment.
Search for getItemLabel and getItemValue in the repo and remove them (even in comments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker -
migrate, getItemLabel, getItemLabelprop deprecation end, remove themigrate, getItemLabel, getItemLabelprop from component usage.Based on #3718
Changelog
Picker -
migrate, getItemLabel, getItemLabelprop deprecation end.Additional info
MADS-4195