Code

Hint Refactor#3486

Code

Open

ethanshar wants to merge 38 commits intomasterwix/react-native-ui-lib:masterfrom infra/hint_refactor_part3wix/react-native-ui-lib:infra/hint_refactor_part3Copy head branch name to clipboard

+3,338-591

Commits

Commits on Dec 23, 2024

• refactor: rename hint rendering methods for clarity

  ethanshar

  committed
  930a844

  Copy full SHA for 930a844

Commits on Dec 25, 2024

• fix: add second hint toggle and adjust hint message positioning

  ethanshar

  committed
  084f150

  Copy full SHA for 084f150

Commits on Dec 29, 2024

• Update src/components/hint/index.tsx

  Show description for 26ef738
  

  ethanshar

  and

  nitzanyiz

  authored
  26ef738

  Copy full SHA for 26ef738

Commits on Dec 31, 2024

• fix: adjust edge margins and target position thresholds in Hint component

  ethanshar

  committed
  3414fff

  Copy full SHA for 3414fff

Commits on Jan 1, 2025

• Merge branch 'master' into fix/hint_position

  ethanshar

  committed
  019f317

  Copy full SHA for 019f317

Commits on Jan 2, 2025

• Add minimum width to Hint component for better layout consistency

  ethanshar

  committed
  a08f6f5

  Copy full SHA for a08f6f5

Commits on Jan 12, 2025

• Merge branch 'master' into fix/hint_position

  ethanshar

  committed
  f651253

  Copy full SHA for f651253

Commits on Jan 13, 2025

• Convert Hint class component to a function component

  ethanshar

  committed
  5afbf8f

  Copy full SHA for 5afbf8f

• Separate old Hint code to another file

  ethanshar

  committed
  c2c3d9b

  Copy full SHA for c2c3d9b

• export error for hint wrap with asBaseComponent

  ethanshar

  committed
  80ed235

  Copy full SHA for 80ed235

• Extract types to another file

  ethanshar

  committed
  40b18be

  Copy full SHA for 40b18be

• Extract animation logic to useHintAnimation

  ethanshar

  committed
  139b8ac

  Copy full SHA for 139b8ac

• Add useHintLayout hook to manage hint layout state and measurements

  ethanshar

  committed
  06006e0

  Copy full SHA for 06006e0

• Move HintProps to types

  ethanshar

  committed
  3228021

  Copy full SHA for 3228021

• cleanups

  ethanshar

  committed
  26ceaac

  Copy full SHA for 26ceaac

• Add useHintAccessibility hook for improved accessibility handling

  ethanshar

  committed
  1543cea

  Copy full SHA for 1543cea

• Add useHintPosition hook for dynamic hint positioning logic

  ethanshar

  committed
  cde322d

  Copy full SHA for cde322d

• Refactor and extract HintMockChildren component

  ethanshar

  committed
  4b38f7b

  Copy full SHA for 4b38f7b

Commits on Jan 14, 2025

• Add HintAnchor component for improved hint rendering and management

  ethanshar

  committed
  598312d

  Copy full SHA for 598312d

Commits on Jan 16, 2025

• Fix render overlay not rendered

  ethanshar

  committed
  5d230ce

  Copy full SHA for 5d230ce

Commits on Jan 21, 2025

• Refactor Hint components for improved structure and layout handling

  ethanshar

  committed
  56bc7d9

  Copy full SHA for 56bc7d9

• Refactor Hint components to use LayoutRectangle for target layout and improve type definitions

  ethanshar

  committed
  4ea0f45

  Copy full SHA for 4ea0f45

• Refactor Hint components to replace TARGET_POSITIONS with TargetAlignments for improved clarity and consistency

  ethanshar

  committed
  a9811ce

  Copy full SHA for a9811ce

• Refactor HintAnchor and useHintPosition components to improve type definitions and enhance clarity in layout handling

  ethanshar

  committed
  c6e1eca

  Copy full SHA for c6e1eca

• Refactor useHintPosition hook to improve target position calculations and enhance clarity in hint positioning logic

  ethanshar

  committed
  0b12ec8

  Copy full SHA for 0b12ec8

• Refactor useHintPosition hook to remove unused targetLayout prop and optimize target alignment calculations

  ethanshar

  committed
  f5016b2

  Copy full SHA for f5016b2

• Merge branch 'master' into infra/hint_refactor_part3

  ethanshar

  committed
  437ced7

  Copy full SHA for 437ced7

• Refactor useHintLayout hook to accept props directly and improve target layout handling

  ethanshar

  committed
  e0fb900

  Copy full SHA for e0fb900

• Update HintsScreen to rename 'Middle Top' to 'Middle Tip' and improve hint key generation for better clarity

  ethanshar

  committed
  f36d7c7

  Copy full SHA for f36d7c7

• Refactor HintBubble import path and clean up useHintPosition hook by removing commented-out code and unnecessary padding logic

  ethanshar

  committed
  ce2d872

  Copy full SHA for ce2d872

Commits on Jan 22, 2025

• Refactor useHintLayout hook to initialize target layout state correctly and handle safe area insets; rename NewHint component to Hint for consistency

  ethanshar

  committed
  e231f4b

  Copy full SHA for e231f4b

Commits on Jan 23, 2025

• Refactor Hint component drivers and tests; update useHintLayout hook to initialize target layout state with targetFrame

  ethanshar

  committed
  86bc627

  Copy full SHA for 86bc627

• Update Hint component snapshots

  ethanshar

  committed
  afc0866

  Copy full SHA for afc0866

• Refactor useHintPosition hook to unify tip position style variable naming for consistency

  ethanshar

  committed
  563f758

  Copy full SHA for 563f758

• Add comment to clarify targetScreenToRelativeOffset calculation in useHintPosition hook

  ethanshar

  committed
  f3b447c

  Copy full SHA for f3b447c

• Merge branch 'master' into infra/hint_refactor_part3

  ethanshar

  committed
  c0c1700

  Copy full SHA for c0c1700

Commits on Feb 3, 2025

• Merge branch 'master' into infra/hint_refactor_part3

  ethanshar

  committed
  5c6dac0

  Copy full SHA for 5c6dac0

• HintsScreen - Update hintKey to include showCustomContent and showReactionStrip for improved uniqueness

  ethanshar

  committed
  95f9e5a

  Copy full SHA for 95f9e5a