Hint Refactor #3486
Open
Hint Refactor #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nitzan Yizhar <[email protected]>
… improve type definitions
…ments for improved clarity and consistency
…finitions and enhance clarity in layout handling
… and enhance clarity in hint positioning logic
…optimize target alignment calculations
…et layout handling
… hint key generation for better clarity
…removing commented-out code and unnecessary padding logic
…ly and handle safe area insets; rename NewHint component to Hint for consistency
…to initialize target layout state with targetFrame
…ming for consistency
…eHintPosition hook
ethanshar
added
the
Important for Next Release
|
@ethanshar The hint with right targetPosition and custom content is broken: |
…ctionStrip for improved uniqueness
The issue is in the HintScreen, It didn't update the key when using the custom content feature |
|
@Inbal-Tish @nitzanyiz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Hint component to make it more readable and maintainable
How to review
I started with breaking this refactor into several different PRs, but TBH I think it's best to just review it as new code from scratch so I submitted only the last PR
Changelog
Refactor and fix Hint component edge case position issues
Additional info