Fix kotlin build issues with react native 73.x
#7831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any status on release for this? |
|
Tests are failing, I'll try to fix the tests this weekend |
Thanks, i did a PR as well (with test failing, what a surprise haha), with a bit more changes to the |
siddarthkay
force-pushed
the
fix-kotlin-issues-with-react-native-73
branch
from
10593c5 to
034f02e
Compare
|
Hi @asafkorem @d4vidi @yogevbd If not could you please provide some assistance here so that we can make progress on this PR :) Thank you |
Otherwise we get errors like this : ``` e: file:///private/tmp/nix-build-status-mobile-build-nightly-android.drv-1/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/topbar/button/ButtonPresenter.kt:196:21 'onInitializeAccessibilityNodeInfo' overrides nothing e: file:///private/tmp/nix-build-status-mobile-build-nightly-android.drv-1/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/topbar/button/ButtonPresenter.kt:200:65 Type mismatch: inferred type is View? but View was expected e: file:///private/tmp/nix-build-status-mobile-build-nightly-android.drv-1/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/topbar/button/ButtonPresenter.kt:200:71 Type mismatch: inferred type is AccessibilityNodeInfoCompat? but AccessibilityNodeInfoCompat was expected ```
These upgrades are needed to deal get playground app to work with java 17
siddarthkay
force-pushed
the
fix-kotlin-issues-with-react-native-73
branch
from
034f02e to
b8e666a
Compare
|
closing in favour of #7864 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we do the following :
react-native-navigationuses java 17 which is needed by react-native 0.73.1gradletask:react-native-navigation:compileReactNative71DebugKotlinfixes #7819
relevant patch in status-mobile repo : https://github.com/status-im/status-mobile/pull/18496/files#diff-b3d31b1df4cceb663a7dba96bcc3ea45686afe2208d7945b6e7e269067d753fbR100-R106