Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(copilot): scroll is not aware of start position param type #4689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(copilot): scroll is not aware of start position param type #4689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c792149
fix(copilot): scroll is not awere of start position param type
yohai109 Jan 19, 2025
0ff9bb1
add spefecing the value range of startPositionX and startPositionY
yohai109 Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions detox/src/copilot/detoxCopilotFrameworkDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ const detoxCopilotFrameworkDriver = {
guidelines: [
'Direction can be "up", "down", "left", or "right".',
'Use `startPositionX` and `startPositionY` to specify the starting point of the scroll gesture.',
'`startPositionX` and `startPositionY` are relative to the element\'s width and height, respectively. with values between 0 and 1.',
'If multiple scroll actions are needed while waiting for an element, use `whileElement()` in conjunction with `waitFor()`.',
],
},
Expand All @@ -109,6 +110,7 @@ const detoxCopilotFrameworkDriver = {
guidelines: [
'Edge can be "top", "bottom", "left", or "right".',
'Use `startPositionX` and `startPositionY` to specify the starting point of the scroll gesture.',
'`startPositionX` and `startPositionY` are relative to the element\'s width and height, respectively. with values between 0 and 1.',
],
},
{
Expand Down
Loading